Skip to content

weblate: 5.6.2 -> 5.7#334849

Merged
fricklerhandwerk merged 4 commits intoNixOS:masterfrom
erictapen:weblate
Aug 19, 2024
Merged

weblate: 5.6.2 -> 5.7#334849
fricklerhandwerk merged 4 commits intoNixOS:masterfrom
erictapen:weblate

Conversation

@erictapen
Copy link
Member

@erictapen erictapen commented Aug 15, 2024

Description of changes

First update to the new Weblate package and module. Builds and deploys on my test instance.

Changelogs:

New packages:

  • python3Packages.cyrtranslit
  • python3Packages.django-otp-webauthn

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@erictapen erictapen requested a review from natsukium as a code owner August 15, 2024 12:38
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 15, 2024
@erictapen erictapen marked this pull request as draft August 15, 2024 12:41
@mweinelt
Copy link
Member

mweinelt commented Aug 15, 2024

Builds and deploys on my test instance.

CSS is 404.

@erictapen
Copy link
Member Author

erictapen commented Aug 15, 2024

Yeah that's why I switched back into draft mode. I'm investigating.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 15, 2024
@erictapen
weblate: 5.6.2 -> 5.7
ca18f1c 
Changelog: https://github.com/WeblateOrg/weblate/releases/tag/weblate-5.7

Also had to rework django-compressor settings and aligned them more
closely with the official docs:
https://cheat.readthedocs.io/en/latest/django/compressor.html
@erictapen
Copy link
Member Author

erictapen commented Aug 15, 2024

Now it should work, had to rework the django-compressor settings.

@erictapen erictapen marked this pull request as ready for review August 15, 2024 14:19
@erictapen
Copy link
Member Author

erictapen commented Aug 15, 2024

@GrahamcOfBorg test weblate

@erictapen
Copy link
Member Author

erictapen commented Aug 19, 2024

I noticed that this also unbreaks the current weblate build, as it currently fails due to dependency version bounds.

Radvendii
Radvendii approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@Radvendii Radvendii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't vouch for the weblate details, but the nix side of things LGTM

@fricklerhandwerk fricklerhandwerk merged commit f5bb4b8 into NixOS:master Aug 19, 2024
dotlambda
dotlambda reviewed Aug 29, 2024
View reviewed changes
@erictapen erictapen mentioned this pull request Aug 29, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda left review comments

@mweinelt mweinelt Awaiting requested review from mweinelt

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

@wegank wegank Awaiting requested review from wegank

@natsukium natsukium Awaiting requested review from natsukium

+1 more reviewer

@Radvendii Radvendii Radvendii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erictapen @mweinelt @Radvendii @dotlambda @fricklerhandwerk